Skip to content

Fix dual input form#260

Closed
PraneshJha1038 wants to merge 3 commits into
komalharshita:mainfrom
PraneshJha1038:fix-dual-input-form
Closed

Fix dual input form#260
PraneshJha1038 wants to merge 3 commits into
komalharshita:mainfrom
PraneshJha1038:fix-dual-input-form

Conversation

@PraneshJha1038

Copy link
Copy Markdown
Contributor

Summary [required]

The PR specifically removes the extra input box at "Find your next project" section of the site, as it was un-necessary, confusing and degraded user experience

Related Issue [required]

Closes #223

Type of Change [required]

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
template/index.html Removed the extra input box from line 351

How to Test This PR [required]

  1. Clone this branch: git checkout your-branch-name
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000
  5. Go to "Find your next project" section
  6. Observe only one skill input box instead of two.

Expected test output:

27 passed, 0 failed out of 27 tests

Test Results [required]

  PASS  test_projects_json_loads
  PASS  test_each_project_has_required_fields
  PASS  test_find_project_by_id_found
  PASS  test_find_project_by_id_missing
  PASS  test_parse_skills_basic
  PASS  test_parse_skills_empty_string
  PASS  test_parse_skills_single_entry
  PASS  test_score_single_project_full_match
  PASS  test_score_single_project_no_match
  PASS  test_get_recommendations_returns_results
  PASS  test_get_recommendations_max_three
  PASS  test_get_recommendations_no_match_returns_empty
  PASS  test_get_recommendations_result_format
  PASS  test_validate_all_valid
  PASS  test_validate_missing_skills
  PASS  test_validate_missing_level
  PASS  test_validate_missing_interest
  PASS  test_validate_missing_time
  PASS  test_validate_all_missing
  PASS  test_home_route
  PASS  test_recommend_api_valid
  PASS  test_recommend_api_missing_field
  PASS  test_recommend_api_empty_body
  PASS  test_project_detail_found
  PASS  test_project_detail_not_found
  PASS  test_internal_server_error_page
  PASS  test_view_code_found
  PASS  test_download_code_found
  PASS  test_scoring_weights_has_all_keys

29 passed, 0 failed out of 29 tests

Screenshots (if UI change)

Before After
image image

Self-Review Checklist [required]

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

None

Add major skills along various domains like languages, tools, database
@vercel

vercel Bot commented May 17, 2026

Copy link
Copy Markdown

@PraneshJha1038 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@PraneshJha1038

PraneshJha1038 commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@komalharshita The issue #260 was the first one to mention the bug about dual input form, and this was the first pr for the respective issue... I don't think this should've had the duplicate tag. As from the log, the merged pr for the same problem was related to issue #267, which was surely created after issue #260. Therefore, i request you to consider the effort gone into this PR, and to add appropriate labels to the pr, for consideration in points for GSSoC'26

@PraneshJha1038

Copy link
Copy Markdown
Contributor Author

@komalharshita Reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists gssoc-2026 type:accessibility ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dual Skill Selection input box

2 participants